-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more fine grained control over blocking elements #1642
base: master
Are you sure you want to change the base?
Allow more fine grained control over blocking elements #1642
Conversation
🦋 Changeset detectedLatest commit: b0a72d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was an effort in #1541 to merge the two previous block methods into one argument that could be passed down. That's not a requirement to get this merged, but just to make note. |
Oh interesting. It seems that they were thinking about something similar: #1541 (comment). Happy to tackle that and remove the other two options, but that would be a breaking change and bigger than just a patch. Also willing to do it as a follow up. |
This PR introduces a new option
blockElementFN
torrweb.record
options. This option allows the consumer to add a callback function to have more control over if the element is blocked or not. This will allow consumers to have a very strict blocking policy and whitelist content.