-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: coerce blockSelector and blockClass to a single concept and reduce branching #1541
Conversation
🦋 Changeset detectedLatest commit: 7d67644 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Discussed with maintainers: we can make this more efficient by constructing a validation function that is then passed down to the serializers |
Closing this in favor of a better alternative |
Do you have the other alternative as a PR @JonasBa ? |
this builds on top of #1536, the idea is to create a single blocking selector and remove some runtime checking and branching inside isBlocked
This is a stacked PR btw, once upstream is merged I will rebase so it'll only contain the related changes