update char type mapping, update to use separated action types #315

dirk-thomas · 2018-11-25T02:59:36Z

char in .msg files has a value range of [0, 255] according to the ROS 1 docs. Therefore it is being mapped to uint8 according to https://github.com/ros2/design/blob/gh-pages/articles/143_legacy_interface_definition.md#mapping-to-idl-types

Significant changes since initial review

dirk-thomas added the in progress Actively being worked on (Kanban column) label Nov 25, 2018

dirk-thomas self-assigned this Nov 25, 2018

dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 26, 2018

mjcarroll previously approved these changes Nov 26, 2018

View reviewed changes

dirk-thomas force-pushed the idl-stage-7 branch from fc12bbf to 6f1a704 Compare November 30, 2018 18:28

dirk-thomas force-pushed the idl-stage-7 branch from 6f1a704 to 01a0272 Compare February 5, 2019 21:06

dirk-thomas mentioned this pull request Feb 12, 2019

Migrate to IDL ros2/rosidl#346

Closed

8 tasks

dirk-thomas force-pushed the idl-stage-7 branch from e6aef9c to 756f1f6 Compare February 12, 2019 21:08

dirk-thomas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Feb 15, 2019

dirk-thomas changed the title ~~update char type mapping~~ update char type mapping, update to use separated action types Feb 19, 2019

dirk-thomas requested a review from mjcarroll February 21, 2019 19:12

dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 21, 2019

dirk-thomas force-pushed the idl-stage-7 branch from 5a83dbb to 7d12c44 Compare February 26, 2019 18:29

mjcarroll approved these changes Feb 26, 2019

View reviewed changes

mjcarroll approved these changes Feb 27, 2019

View reviewed changes

dirk-thomas force-pushed the idl-stage-7 branch from 17a7c17 to 67eaa4f Compare March 4, 2019 18:14

dirk-thomas added 6 commits March 7, 2019 15:04

update char type mapping

d05c3a7

match renamed action types

f3aa2c5

use correct term

9da89f1

change char type values

b1460c3

make the build pass for now

f7b8611

update action API

55c2fab

dirk-thomas force-pushed the idl-stage-7 branch from 67eaa4f to 55c2fab Compare March 7, 2019 23:05

update action API

d3010ee

dirk-thomas force-pushed the idl-stage-7 branch from 3bc0f3b to d3010ee Compare March 10, 2019 06:06

dirk-thomas merged commit e9b0360 into master Mar 12, 2019

dirk-thomas deleted the idl-stage-7 branch March 12, 2019 04:13

dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 12, 2019

Provide feedback