Skip to content

Commit

Permalink
update action API
Browse files Browse the repository at this point in the history
  • Loading branch information
dirk-thomas committed Mar 10, 2019
1 parent 55c2fab commit d3010ee
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions test_communication/test/action_client_py.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ def generate_fibonacci_goal_tests():

test = ActionClientTest(goal)

def is_feedback_valid(feedback):
def is_feedback_valid(feedback_message):
feedback = feedback_message.feedback
if len(feedback.sequence) > (order + 1):
print('Feedback sequence is greater than goal order', file=sys.stderr)
return False
Expand All @@ -107,7 +108,8 @@ def is_feedback_valid(feedback):
return False
return True

def is_result_valid(result):
def is_result_valid(get_result_response):
result = get_result_response.result
if len(result.sequence) != (order + 1):
print('Result sequence does not equal goal order', file=sys.stderr)
return False
Expand Down Expand Up @@ -138,15 +140,17 @@ def generate_nested_message_goal_tests():

test = ActionClientTest(goal)

def is_feedback_valid(feedback):
def is_feedback_valid(feedback_message):
feedback = feedback_message.feedback
if feedback.nested_different_pkg.sec != expected_feedback_value:
print('Expected feedback {} but got {} for initial value {}'.format(
expected_feedback_value, feedback.nested_different_pkg.sec, initial_value),
file=sys.stderr)
return False
return True

def is_result_valid(result):
def is_result_valid(get_result_response):
result = get_result_response.result
if result.nested_field.int32_value != expected_result_value:
print('Expected result {} but got {} for initial value {}'.format(
expected_result_value, result.nested_field.int32_value, initial_value),
Expand Down

0 comments on commit d3010ee

Please sign in to comment.