Refactor typesupport #15
Conversation
...typesupport_opensplice_cpp/cmake/rosidl_typesupport_opensplice_cpp_generate_interfaces.cmake
Show resolved
Hide resolved
...typesupport_opensplice_cpp/cmake/rosidl_typesupport_opensplice_cpp_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
rosidl_typesupport_opensplice_cpp/resource/msg__type_support.cpp.em
Outdated
Show resolved
Hide resolved
| @[ elif field.type.is_primitive_type()]@ | ||
| dds_message.@(field.name)_[i] = ros_message.@(field.name)[i]; | ||
| @[ if isinstance(member.type.basetype, BaseString)]@ | ||
| dds_message.@(member.name)_[i] = ros_message.@(member.name)[i].c_str(); |
There was a problem hiding this comment.
I am not sure if c_str is going to work for WStrings.
There was a problem hiding this comment.
You're probably right, unless the ROS message is using a std::wstring. How is a WString represented in the ROS message and what should we do for the conversion?
There was a problem hiding this comment.
We don't have any examples / tests for that yet. The representation of WString in each language is described here: https://github.com/ros2/design/blob/gh-pages/articles/142_idl.md#type-mapping
There was a problem hiding this comment.
Ok, since WString is described as having type std::u16string, I think the use of c_str() should work since it is a std::basic_string.
dirk-thomas
force-pushed
the
idl-stage-7
branch
from
7116703 to
f41c7c5
Compare
jacobperron
force-pushed
the
jacob/idl-stage-7
branch
from
34527d1 to
f0c86ae
Compare
jacobperron
force-pushed
the
jacob/idl-stage-7
branch
from
3754341 to
53b2074
Compare
Moved header guards to top-level files. Prepend type names to static variables.
jacobperron
added
in review
|
CI with
|
|
Once this passes CI please (squash) merge this into |
|
CI with
|
|
The |
Looking for early feedback. I think the EmPy templates are complete, but there is still some CMake business to do.