Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change generators to IDL-based pipeline #39

Merged
merged 11 commits into from
Mar 12, 2019
Merged

change generators to IDL-based pipeline #39

merged 11 commits into from
Mar 12, 2019

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Nov 21, 2018 •
edited
Loading

Another PR integrating ros2/rosidl#298 step-by-step.

Connected to ros2/rosidl#334

  • It updates the includes of the generated code to match the reduced number of generated files.
  • It updates the rosidl_typesupport_c and rosidl_typesupport_cpp packages to use the new IDL-based extension points.

@dirk-thomas dirk-thomas added enhancement New feature or request in progress Actively being worked on (Kanban column) labels Nov 21, 2018
@dirk-thomas dirk-thomas self-assigned this Nov 21, 2018
@dirk-thomas dirk-thomas force-pushed the idl-stage-7 branch 3 times, most recently from e267a04 to f3330ed Compare November 26, 2018 06:10
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 26, 2018
hidmic
hidmic reviewed Nov 27, 2018
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments. I see the pattern emerging across PRs and I worry about duplication a bit.

@dirk-thomas dirk-thomas mentioned this pull request Feb 12, 2019
Closed
8 tasks
@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Feb 15, 2019
@dirk-thomas dirk-thomas changed the title update rosidl_typesupport_c and cpp to use IDL pipeline change generators to IDL-based pipeline Feb 19, 2019
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 21, 2019
hidmic
hidmic approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@dirk-thomas dirk-thomas merged commit e6c4fce into master Mar 12, 2019
@dirk-thomas dirk-thomas deleted the idl-stage-7 branch March 12, 2019 04:11
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees

@dirk-thomas dirk-thomas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirk-thomas @sloretz @hidmic