Get list of typesupports from ament index #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquelinekay
force-pushed
the
register_typesupport_language
branch
from
819e2d3 to
f16ff8a
Compare
|
I'm going to address the hardcoded identifier map in a separate pull request. |
jacquelinekay
force-pushed
the
register_typesupport_language
branch
from
59fe715 to
7c7826d
Compare
jacquelinekay
force-pushed
the
register_typesupport_language
branch
2 times, most recently
from
d19ef33 to
5a075ad
Compare
| @@ -44,9 +40,10 @@ def import_type_support(pkg_name, subfolder, rosidl_name, rmw_implementation): | |||
| :param rmw_implementation str: name of the rmw implementation | |||
| :returns: the type support Python module for this specific rosidl and rmw implementation pair | |||
| """ | |||
| if rmw_implementation not in type_support_map.keys(): | |||
| if not ament_index_python.has_resource("rmw_typesupport_c", rmw_implementation): | |||
|
I removed an extra empty line in ae15542 |
jacquelinekay
force-pushed
the
register_typesupport_language
branch
from
d690b2d to
89e35b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#63
Use
get_rmw_typesupport_cinstead of a hardcoded list of typesupport implementations.There is still a hardcoded ignore rule for fastrtps.
There is also a hardcoded map in
import_type_support_impl.py. I wasn't sure how to fix this but perhapsament_index_pythoncould be used?