Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis -> Github actions. #948

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Switch from Travis -> Github actions. #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Test

on: [push, pull_request]

jobs:
test:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2

- name: Setup Python
uses: actions/setup-python@v1
with:
python-version: 3.8

- name: Install dependencies with pip
run: |
pip install doc8 sphinx
pip install git+https://github.com/osrf/sphinx-tabs
- run: make html 2> stderr.log
- run: cat stderr.log
- run: doc8 --ignore D001 --ignore-path build --ignore-path source/Tutorials/Actions
# ignore D000 in action tutorials to allow for :linenos:
- run: doc8 --ignore D000 --ignore D001 --ignore-path build source/Tutorials/Actions
Comment on lines +21 to +25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious why you chose to put each command in a separate run: entry versus something like

      - run: |
          make html 2> stderr.log
          cat stderr.log
          doc8 --ignore D001 --ignore-path build --ignore-path source/Tutorials/Actions
          # ignore D000 in action tutorials to allow for :linenos:
          doc8 --ignore D000 --ignore D001 --ignore-path build source/Tutorials/Actions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm being honest, I did it that way because the tutorial I was following did it that way :).

I don't feel strongly about it, but I actually like the separated run statements a bit better now that I see it deployed. Each separate run statement gets its own block, which makes it kind of easy to see exactly what failed when a step failed.

# fail the build for any stderr output
- run: if [ -s "stderr.log" ]; then false; fi
18 changes: 0 additions & 18 deletions .travis.yml
View file
Open in desktop

This file was deleted.