-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Travis -> Github actions. #948
Conversation
Signed-off-by: Chris Lalancette <[email protected]>
(we'll also have to port this to the versioned branches) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- run: make html 2> stderr.log | ||
- run: cat stderr.log | ||
- run: doc8 --ignore D001 --ignore-path build --ignore-path source/Tutorials/Actions | ||
# ignore D000 in action tutorials to allow for :linenos: | ||
- run: doc8 --ignore D000 --ignore D001 --ignore-path build source/Tutorials/Actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just curious why you chose to put each command in a separate run:
entry versus something like
- run: |
make html 2> stderr.log
cat stderr.log
doc8 --ignore D001 --ignore-path build --ignore-path source/Tutorials/Actions
# ignore D000 in action tutorials to allow for :linenos:
doc8 --ignore D000 --ignore D001 --ignore-path build source/Tutorials/Actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm being honest, I did it that way because the tutorial I was following did it that way :).
I don't feel strongly about it, but I actually like the separated run statements a bit better now that I see it deployed. Each separate run
statement gets its own block, which makes it kind of easy to see exactly what failed when a step failed.
@Mergifyio backport rolling |
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090) # Conflicts: # .travis.yml
Command
|
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090)
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090 and commit 9289f21)
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090 and commit 9289f21) Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090 and commit 9289f21) Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 893694a)
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090 and commit 9289f21) Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 893694a)
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090 and commit 9289f21) Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 893694a) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090 and commit 9289f21) Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 893694a) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090 and commit 9289f21) Co-authored-by: Chris Lalancette <[email protected]>
* Switch to use new GA4 analytics tag (#3421) The old one is being sunset and won't work for much longer (cherry picked from commit ac56356) # Conflicts: # conf.py * Fixing merge failure by adding theme and theme options Fixing syntax for backporting. We're using this theme so hopefully backporting the alternative settings will work too. * add missing requirements for build * Switch from Travis -> Github actions. (#948) (#953) Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit dab7090 and commit 9289f21) Co-authored-by: Chris Lalancette <[email protected]> * add rtd theme requirement Signed-off-by: Tully Foote <[email protected]> --------- Signed-off-by: Tully Foote <[email protected]> Co-authored-by: Tully Foote <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Tully Foote <[email protected]>
Signed-off-by: Chris Lalancette [email protected]