Fix connext references #1266
Merged
Fix connext references #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asorbini
reviewed
Mar 26, 2021
clalancette
force-pushed
the
clalancette/rolling-fix-connext
branch
from
7612c5b to
3aa1b18
Compare
asorbini
reviewed
Mar 26, 2021
asorbini
suggested changes
Mar 29, 2021
|
@asorbini I've fixed the issues you pointed out. Ready for another review pass, thanks. |
asorbini
reviewed
Mar 29, 2021
asorbini
approved these changes
Mar 29, 2021
|
I'm going to go ahead and merge this one. Anything else that we find we can fix up in a follow-up. Thanks for the review! |
While we are in here, also slightly rewrite some phrases to make it more up-to-date. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
clalancette/rolling-fix-connext
branch
from
378053e to
a188cf5
Compare
This was referenced Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new RMW going into Galactic, so this PR replaces all of the old references of
rmw_connext_cppwithrmw_connextdds. It also adds a separate commit to add a release note to the Galactic release notes; that one commit will be backported to the foxy and dashing branches.This PR should not be merged until the work in ros2/rmw_connextdds#9 is completed.