Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend rmw_qos_policy_kind_t, add functions to convert it to/from a string #285

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Extend rmw_qos_policy_kind_t, add functions to convert it to/from a string #285

merged 2 commits into from
Oct 19, 2020

Conversation

ivanpauno
Copy link
Member

Follow-up of #284.
Useful for ros2/rclcpp#1408.

What this PR does?:

@ivanpauno
Move rmw_qos_policy_kind_t to an independent header, extend its defin…
5f2607f 
…ition to cover all qos policies

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add policy kind to string conversions
f7dbbff 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno added the enhancement New feature or request label Oct 19, 2020
@ivanpauno ivanpauno requested a review from jacobperron October 19, 2020 19:17
@ivanpauno ivanpauno self-assigned this Oct 19, 2020
@ivanpauno ivanpauno mentioned this pull request Oct 19, 2020
Merged
10 tasks
jacobperron
jacobperron approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit a223f92 into master Oct 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/qos-policy-kind branch October 19, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @jacobperron