Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add types to Action Server and Action Client (#1349)" #1359

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Sep 18, 2024

This reverts commit d1d7d05.

Depends on #1360

@fujitatomoya
Copy link
Collaborator Author

Pulls: #1359
Gist: https://gist.githubusercontent.com/fujitatomoya/dc3dbdca7e7553654c89d121b442b0e8/raw/89d37c0497ab232f028da4e80437b838a81c2b98/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14576

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Copy link
Contributor

Just fyi #1345 built off changes done in #1349 So that is why you are receiving failures.

@fujitatomoya
Copy link
Collaborator Author

@InvincibleRMC so we should revert #1345 together? what do you suggest?

@InvincibleRMC
Copy link
Contributor

Until we can sort out the failure I think we have to unfortunately.

@InvincibleRMC
Copy link
Contributor

I have some potential ideas for what could be causing problems with the rhel failures but don't have enough confidence for an exact cause without having access to a rhel system.

@fujitatomoya
Copy link
Collaborator Author

@InvincibleRMC thanks for taking care of this.

I have some potential ideas for what could be causing problems with the rhel failures but don't have enough confidence for an exact cause without having access to a rhel system.

i think we can give it a shot, once you create the PR, i can start the CI with RHEL.

Until we can sort out the failure I think we have to unfortunately.

So what we should do is the following, right? just checking.

  1. revert Executors types #1345
  2. revert Add types to Action Server and Action Client #1349 (this PR)

@InvincibleRMC
Copy link
Contributor

Yes that seems the best course of action to me

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/revert-pr-1349 branch from e8fd0ce to 88f3316 Compare September 18, 2024 17:16
@fujitatomoya
Copy link
Collaborator Author

#1360 has been merged, so i just did the rebase this PR against rolling. i will start the CI again.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #1359
Gist: https://gist.githubusercontent.com/fujitatomoya/cd35936b4f64d833241eef04925e2712/raw/89d37c0497ab232f028da4e80437b838a81c2b98/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14579

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

windows failure is unrelated https://ci.ros2.org/job/ci_windows/22567/, i will go ahead to merge this revert PR.

@fujitatomoya fujitatomoya merged commit 2de5c8e into rolling Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants