-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add types to Action Server and Action Client (#1349)" #1359
Conversation
Pulls: #1359 |
@InvincibleRMC so we should revert #1345 together? what do you suggest? |
Until we can sort out the failure I think we have to unfortunately. |
I have some potential ideas for what could be causing problems with the rhel failures but don't have enough confidence for an exact cause without having access to a rhel system. |
@InvincibleRMC thanks for taking care of this.
i think we can give it a shot, once you create the PR, i can start the CI with RHEL.
So what we should do is the following, right? just checking.
|
Yes that seems the best course of action to me |
This reverts commit d1d7d05. Signed-off-by: Tomoya Fujita <[email protected]>
e8fd0ce
to
88f3316
Compare
#1360 has been merged, so i just did the rebase this PR against rolling. i will start the CI again. |
Pulls: #1359 |
windows failure is unrelated https://ci.ros2.org/job/ci_windows/22567/, i will go ahead to merge this revert PR. |
This reverts commit d1d7d05.
Depends on #1360