Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to Action Server and Action Client #1349

Merged
merged 13 commits into from
Sep 7, 2024
Merged

Add types to Action Server and Action Client #1349

merged 13 commits into from
Sep 7, 2024

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

@InvincibleRMC
Add types to Action objects
46a3488 
Signed-off-by: Michael Carlstrom <[email protected]>
fujitatomoya
fujitatomoya approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya
Copy link
Collaborator

Pulls: #1349
Gist: https://gist.githubusercontent.com/fujitatomoya/d1c28940dae674d54c74566a19bfc13b/raw/8844303445a5a3b903daea42dbae4862b475ffc4/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14507

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
move import into TYPE_CHECKING block
e62e77f 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Copy link
Contributor Author

@fujitatomoya There was an import error. It should be fixed now.

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Type over type
423976a 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add ClassVar
85227ae 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Copy link
Contributor Author

@fujitatomoya Fixed a bad import for Python3.8 so Windows should now pass.

@fujitatomoya
Copy link
Collaborator

  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Copy link
Contributor Author

@fujitatomoya is this good to merge?

@fujitatomoya
Copy link
Collaborator

Last CI unstable warnings are unrelated to this PR.

@fujitatomoya fujitatomoya merged commit d1d7d05 into ros2:rolling Sep 7, 2024
3 checks passed
@InvincibleRMC InvincibleRMC deleted the action-types branch September 7, 2024 20:29
@fujitatomoya fujitatomoya mentioned this pull request Sep 7, 2024
Merged
@clalancette clalancette mentioned this pull request Sep 17, 2024
Closed
@clalancette
Copy link
Contributor

Just as an FYI, this is probably the cause of ros2/ros2cli#932 . Since it is so large it is somewhat hard to figure out exactly what is happening, but we'll need to examine it more closely.

@InvincibleRMC InvincibleRMC restored the action-types branch September 17, 2024 23:03
@fujitatomoya
Copy link
Collaborator

@clalancette thanks for checking that. i am okay to revert this fix, are you also going to do that? CC: @InvincibleRMC

@InvincibleRMC
Copy link
Contributor Author

Re-looking at the changes I made nothing seems obvious that would make it seg fault sometimes only on rhel. But reverting and splitting into smaller PRs seems wise.

fujitatomoya added a commit that referenced this pull request Sep 18, 2024
@fujitatomoya
Revert "Add types to Action Server and Action Client (#1349)"
e8fd0ce 
This reverts commit d1d7d05.

Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator

revert PR: #1359

@InvincibleRMC InvincibleRMC mentioned this pull request Sep 18, 2024
Merged
fujitatomoya added a commit that referenced this pull request Sep 18, 2024
@fujitatomoya
Revert "Add types to Action Server and Action Client (#1349)"
88f3316 
This reverts commit d1d7d05.

Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit that referenced this pull request Sep 20, 2024
@fujitatomoya
Revert "Add types to Action Server and Action Client (#1349)" (#1359)
2de5c8e 
This reverts commit d1d7d05.

Signed-off-by: Tomoya Fujita <[email protected]>
@InvincibleRMC InvincibleRMC mentioned this pull request Sep 21, 2024
Merged
@InvincibleRMC InvincibleRMC mentioned this pull request Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@sloretz sloretz Awaiting requested review from sloretz

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvincibleRMC @fujitatomoya @clalancette