Add types to qos_overriding_options.py #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <[email protected]>
InvincibleRMC
requested review from
sloretz and
adityapande-1995
as code owners
fujitatomoya
approved these changes
Mar 12, 2024
sloretz
approved these changes
Mar 13, 2024
|
CI (repos file build:
|
Signed-off-by: Michael Carlstrom <[email protected]>
|
it should be fixed and green CI, starting another try. CI:
|
Any idea why libyaml_vendor has been running for over a day? |
|
I have no idea, it just said
|
|
Now that CI has passed are we waiting on anything to merge this in? |
|
@InvincibleRMC No, this is good to go. |
InvincibleRMC
added a commit
to InvincibleRMC/rclpy
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
sloretz
added a commit
that referenced
this pull request
Aug 2, 2024
* Add types to parameter.py Signed-off-by: Michael Carlstrom <[email protected]> * Revert "Add types to TypeHash and moved away from __slots__ usage (#1232)" (#1243) This reverts commit b06baef. Signed-off-by: Michael Carlstrom <[email protected]> * Add back Type hash __slots__ and add test cases. (#1245) * Add types to TypeHash and add test cases Signed-off-by: Michael Carlstrom <[email protected]> * Add types to context.py (#1240) Signed-off-by: Michael Carlstrom <[email protected]> * Add types to qos_overriding_options.py (#1248) Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> * Small fixes for modern flake8. (#1264) It doesn't like to compare types with ==, so switch to isinstance as appropriate. Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> * Add types to time_source.py (#1259) * Add types to time_source.py Signed-off-by: Michael Carlstrom <[email protected]> * fix small bug Signed-off-by: Michael Carlstrom <[email protected]> * Switch to overloads to avoid mypy3737 Signed-off-by: Michael Carlstrom <[email protected]> * Update parameter declaration from Node Signed-off-by: Michael Carlstrom <[email protected]> * add back rclpy. Signed-off-by: Michael Carlstrom <[email protected]> * Fix flake8 imports Signed-off-by: Michael Carlstrom <[email protected]> * Add proper array.array[] Signed-off-by: Michael Carlstrom <[email protected]> * Update types of declare_parameter, declare_parameters api Signed-off-by: Michael Carlstrom <[email protected]> * Add non conflicting types back to constructor Signed-off-by: Michael Carlstrom <[email protected]> * Move sys import Signed-off-by: Michael Carlstrom <[email protected]> * Update error message Signed-off-by: Michael Carlstrom <[email protected]> * Add default value for generic Parameter Signed-off-by: Michael Carlstrom <[email protected]> * Add explanation comment Signed-off-by: Michael Carlstrom <[email protected]> * Add TypeVar import inside else case Signed-off-by: Michael Carlstrom <[email protected]> * push to rerun ci Signed-off-by: Michael Carlstrom <[email protected]> * push to rerun ci Signed-off-by: Michael Carlstrom <[email protected]> * Switch back to union Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.