update style #445
update style #445
Conversation
| typename std::allocator<void>::template rebind<T>::other>::value, | ||
| std::default_delete<T>, | ||
| AllocatorDeleter<Alloc> | ||
| >::type; |
There was a problem hiding this comment.
This is better. It's unfortunate that the last line >::type isn't indented one less (should end on the same column as the line that starts it).
There was a problem hiding this comment.
A similar comment applies to all follow multi-line templates.
There was a problem hiding this comment.
When targeting the latest release this "improvement" is sadly not possible. Therefore I revert this change.
rclcpp/include/rclcpp/exceptions.hpp
Outdated
| @@ -116,7 +116,7 @@ throw_from_rcl_error( | |||
| rcl_ret_t ret, | |||
| const std::string & prefix = "", | |||
| const rcl_error_state_t * error_state = nullptr, | |||
| void (*reset_error)() = rcl_reset_error); | |||
| void (* reset_error)() = rcl_reset_error); | |||
There was a problem hiding this comment.
Not sure this is better (more correct), but I'm fine with it too.
|
|
||
| template<typename FunctorT, typename ... Args> | ||
| struct check_arguments : std::is_same< | ||
| typename function_traits<FunctorT>::arguments, | ||
| std::tuple<Args ...> | ||
| > | ||
| > |
There was a problem hiding this comment.
This one has the right indentation for the closing >, but does 4 spaces rather than two on the inside... Which is somehow the counterpart of the one I commented on above. If only we could combine the two...
dirk-thomas
force-pushed
the
uncrustify_master
branch
2 times, most recently
from
04071cf to
0ce598b
Compare
dirk-thomas
force-pushed
the
uncrustify_master
branch
from
0ce598b to
3907e16
Compare
Signed-off-by: Abby Xu <[email protected]>
Connect to
ament/uncrustify#20. Connect to ament/uncrustify#21.Ready for review.