Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass const references to parameters client API #142

Merged
merged 1 commit into from
Nov 2, 2015
Merged

Pass const references to parameters client API #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions rclcpp/include/rclcpp/parameter_client.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class AsyncParametersClient

std::shared_future<std::vector<rclcpp::parameter::ParameterVariant>>
get_parameters(
std::vector<std::string> names,
const std::vector<std::string> & names,
std::function<void(
std::shared_future<std::vector<rclcpp::parameter::ParameterVariant>>)> callback = nullptr)
{
Expand Down Expand Up @@ -108,7 +108,7 @@ class AsyncParametersClient

std::shared_future<std::vector<rclcpp::parameter::ParameterType>>
get_parameter_types(
std::vector<std::string> names,
const std::vector<std::string> & names,
std::function<void(
std::shared_future<std::vector<rclcpp::parameter::ParameterType>>)> callback = nullptr)
{
Expand Down Expand Up @@ -140,7 +140,7 @@ class AsyncParametersClient

std::shared_future<std::vector<rcl_interfaces::msg::SetParametersResult>>
set_parameters(
std::vector<rclcpp::parameter::ParameterVariant> parameters,
const std::vector<rclcpp::parameter::ParameterVariant> & parameters,
std::function<void(std::shared_future<std::vector<rcl_interfaces::msg::SetParametersResult>>)> callback =
nullptr)
{
Expand Down Expand Up @@ -170,7 +170,7 @@ class AsyncParametersClient

std::shared_future<rcl_interfaces::msg::SetParametersResult>
set_parameters_atomically(
std::vector<rclcpp::parameter::ParameterVariant> parameters,
const std::vector<rclcpp::parameter::ParameterVariant> & parameters,
std::function<void(std::shared_future<rcl_interfaces::msg::SetParametersResult>)> callback =
nullptr)
{
Expand Down Expand Up @@ -200,7 +200,7 @@ class AsyncParametersClient

std::shared_future<rcl_interfaces::msg::ListParametersResult>
list_parameters(
std::vector<std::string> prefixes,
const std::vector<std::string> & prefixes,
uint64_t depth,
std::function<void(std::shared_future<rcl_interfaces::msg::ListParametersResult>)> callback =
nullptr)
Expand Down Expand Up @@ -271,7 +271,7 @@ class SyncParametersClient
}

std::vector<rclcpp::parameter::ParameterVariant>
get_parameters(std::vector<std::string> parameter_names)
get_parameters(const std::vector<std::string> & parameter_names)
{
auto f = async_parameters_client_->get_parameters(parameter_names);
if (rclcpp::executors::spin_node_until_future_complete(*executor_, node_, f) ==
Expand All @@ -284,7 +284,7 @@ class SyncParametersClient
}

std::vector<rclcpp::parameter::ParameterType>
get_parameter_types(std::vector<std::string> parameter_names)
get_parameter_types(const std::vector<std::string> & parameter_names)
{
auto f = async_parameters_client_->get_parameter_types(parameter_names);

Expand All @@ -297,7 +297,7 @@ class SyncParametersClient
}

std::vector<rcl_interfaces::msg::SetParametersResult>
set_parameters(std::vector<rclcpp::parameter::ParameterVariant> parameters)
set_parameters(const std::vector<rclcpp::parameter::ParameterVariant> & parameters)
{
auto f = async_parameters_client_->set_parameters(parameters);

Expand All @@ -310,7 +310,7 @@ class SyncParametersClient
}

rcl_interfaces::msg::SetParametersResult
set_parameters_atomically(std::vector<rclcpp::parameter::ParameterVariant> parameters)
set_parameters_atomically(const std::vector<rclcpp::parameter::ParameterVariant> & parameters)
{
auto f = async_parameters_client_->set_parameters_atomically(parameters);

Expand All @@ -325,7 +325,7 @@ class SyncParametersClient

rcl_interfaces::msg::ListParametersResult
list_parameters(
std::vector<std::string> parameter_prefixes,
const std::vector<std::string> & parameter_prefixes,
uint64_t depth)
{
auto f = async_parameters_client_->list_parameters(parameter_prefixes, depth);
Expand Down