Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem of not enabling multi-layered namespace #743

Closed
LeonJung opened this issue May 27, 2019 · 3 comments
Closed

Problem of not enabling multi-layered namespace #743

LeonJung opened this issue May 27, 2019 · 3 comments
Labels
more-information-needed Further information is required

Comments

@LeonJung
Copy link

LeonJung commented May 27, 2019

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04
  • Installation type:
    • src
  • Version or commit hash:
    • 0.6.2
  • DDS implementation:
    • Any
  • Client library (if applicable):
    • rclcpp

I couldn't put multi-layered namespace with the one in ros2 launch and another one in rclcpp::Node

Theoretically, the system should put the namespace set in launch file over the namespace set in Node instance parameter (and also the node name after that). However, the namespace in launch file overwrites another one, not caring whether is set or not. And therefore, the namespace removes the parameter wrapped by another namespace.

I actually tested putting namespace as "namespace1/namespace2" in Node function, and it works but not showing as "namespace2" in "namespace1" but as "namespace1/namespace2". So I guessed if the multi-layered namespace is really enabled in ros2.

Am I doing well or is there anyone having other way to wrap with launch namespace

Thanks

@nuclearsandwich
Copy link
Member

Can you please share an example launch file and steps to reproduce the problem as you see it? Being able to reproduce it will help us determine whether the current behavior is expected or not.

@ivanpauno
Copy link
Member

ivanpauno commented Jul 18, 2019

@LeonJung I don't fully understand your description of the problem, but this may be related ros2/launch_ros#42.

@nuclearsandwich nuclearsandwich added the more-information-needed Further information is required label Jul 25, 2019
@wjwwood
Copy link
Member

wjwwood commented Mar 23, 2020

I haven't heard from you in a bit (which is totally fine!), but because of that I'm going to close this. If you're still working on it, feel free to speak up and I'll open it back up, or if you don't have time right now but do in the future, speak up then and I can open it again at that point.

Thanks!

@wjwwood wjwwood closed this as completed Mar 23, 2020
nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
* Add bomb allocator
* Fix memory checked for error
* Add tests for bad alloc
* Fix break statement
* Add static keyword to methods added

Signed-off-by: Jorge Perez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

No branches or pull requests

4 participants