-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PushRosNamespace action #42
Conversation
Signed-off-by: ivanpauno <[email protected]>
Signed-off-by: ivanpauno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
That is fine by me, though we have to address the namespacing in XML or instead of having new versions that "overload", find a way to extend the actions that are already in
I think it would be ok to do this at the XML level, but I would not do this at the action level. I intentionally left scoping to groups as to not complicate every action that might benefit from scoping, like the include action and the set launch configuration action. |
I would also not change the default behavior of scoping in the Python API, but again, I think that could be appropriate in the XML syntactic sugar. |
Signed-off-by: ivanpauno <[email protected]>
Double checking if linter is happy after 5b64bd7: |
Based on discussion ros2/design#207 (review), ros2/design#207 (comment), and inspired on
Node
action documentation (of a feature that was documented but not implemented).This adds a way of scoping ROS entities in a namespace.
Example usage:
I think we should consider in the future:
GroupAction
andIncludeLaunchDescription
alternatives inlaunch_ros
. Add to them an extraros_namespace
argument.scoped
argument toIncludeLaunchDescription
action (inlaunch
), default toTrue
(which will break api, but I think is more "normal").