Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread dependency to examples (Rolling) #237

Merged
merged 13 commits into from
Jan 25, 2022
Merged

Conversation

Acuadros95
Copy link
Collaborator

@Acuadros95 Acuadros95 commented Jan 19, 2022

Related to #235

Copy link

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to call find_package(Threads), but otherwise this PR seem to be adding the dependency in the correct place.

@codecov-commenter
Copy link

Codecov Report

Merging #237 (196d0f9) into master (5ea1a2a) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   63.51%   63.42%   -0.10%     
==========================================
  Files          16       16              
  Lines        2149     2149              
  Branches      641      641              
==========================================
- Hits         1365     1363       -2     
- Misses        471      472       +1     
- Partials      313      314       +1     
Impacted Files Coverage Δ
rclc/src/rclc/action_goal_handle.c 59.87% <0.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea1a2a...196d0f9. Read the comment docs.

Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
@JanStaschulat
Copy link
Contributor

JanStaschulat commented Jan 24, 2022

@sloretz @pablogs9 Thanks a lot for your valuable feedback. @Acuadros95 thanks you for taking action.

The dependency configuration of the rclc_examples package is now updated accordingly:

find_package(Threads REQUIRED)
target_link_libraries(example_action_server Threads::Threads)

in rclc_examples\CMakeLists.txt without changing other packages of the rclc-repository.
Additionally, I had to resolve some uncrustify and cpplint erros.

Are you both okay with these changes? If yes, I would like to ask you to review and approve this PR. I will then create a new bloom-release for Rolling.

Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanStaschulat JanStaschulat merged commit 0a49ce1 into master Jan 25, 2022
@JanStaschulat JanStaschulat deleted the fix/thread branch January 25, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants