-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thread dependency to examples (Rolling) #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to call find_package(Threads)
, but otherwise this PR seem to be adding the dependency in the correct place.
#include <pthread.h> |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 63.51% 63.42% -0.10%
==========================================
Files 16 16
Lines 2149 2149
Branches 641 641
==========================================
- Hits 1365 1363 -2
- Misses 471 472 +1
- Partials 313 314 +1
Continue to review full report at Codecov.
|
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
@sloretz @pablogs9 Thanks a lot for your valuable feedback. @Acuadros95 thanks you for taking action. The dependency configuration of the
in Are you both okay with these changes? If yes, I would like to ask you to review and approve this PR. I will then create a new bloom-release for Rolling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #235