-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove turtlesim velocity and use Twist msg #5
Conversation
Is geometry_msgs missing from the package.xml and CMakeLists? Otherwise, each substitution looks good. Will the tutorial pages need updated? +1 to changing "turtle1/command_velocity", etc to "turtle1/cmd_vel" Does everyone think that allowing the 'Pose' message to continue is fine? Otherwise, we would have to introduce quaternion logic at this point... and pull in tf to do getYawFromQuaternion and getQuaternionFromYaw, etc. |
I was unsure whether I should use geometry_msgs/Pose. Because Turtlesim/pose was providing both positions and velocity. |
The standard for Pose + Velocities is nav_msgs/Odometry: However, like I said, orientation is given as a quaternion, so I'm not sure if it's worth including in the tutorials. On the other hand, users have to get used to quaternions eventually. :) |
How is odometry related to that? |
It's the most standard message we have for a robot reporting its position, orientation, linear velocities, and angular velocities. The turtlesim/Pose message is a simplified nav_msgs/Odometry. |
@dirk-thomas Both Odometry and turtlesim/Pose are providing position and velocity. |
This issue is about the velocity message and topic name. Not about the pose and we should keep it that way. |
Code changes look fine. But turtlesim does not depend on package which provides the Twist msg. |
package.xml and Cmakelist updated. I wonder why it was compiling without this dependency though. |
it was not alphabetic order... |
remove turtlesim velocity and use Twist msg
Turtlesim with Twist message