Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turtlesim should use geometry_msgs/Twist and /cmd_vel #4

Closed
chadrockey opened this issue Nov 21, 2012 · 9 comments
Closed

turtlesim should use geometry_msgs/Twist and /cmd_vel #4

chadrockey opened this issue Nov 21, 2012 · 9 comments

Comments

@chadrockey
Copy link
Member

In this tutorial:
http://www.ros.org/wiki/ROS/Tutorials/UnderstandingTopics

We seem to suggest that robots should implement their own command message (turtlesim/Velocity). That's not correct, so we should show have turtlesim use /cmd_vel topics and geometry_msgs/Twist as is truly standard. Users often start their own software based on tutorials, so we need to make sure the tutorials follow standard practices.

@ahendrix
Copy link

+1

@dirk-thomas
Copy link
Member

Either someone provides a complete patch to modify the code and the wiki accordingly or we should just add a note stating that to the existing tutorial.

@jihoonl
Copy link
Contributor

jihoonl commented Feb 4, 2013

@dirk-thomas I just requested pull request to use Twist msg. Would you check it?

@dirk-thomas
Copy link
Member

Pull request #5

@dirk-thomas
Copy link
Member

Would you also update the pull request to use the cmd_vel topic?

@jihoonl
Copy link
Contributor

jihoonl commented Feb 4, 2013

Change pushed.

@dirk-thomas
Copy link
Member

The patch has been merged. The Wiki page must be updated but only after a new release is in the public repo.

@chadrockey
Copy link
Member Author

For hydro right? We don't want to risk that someone out there probably
depends on that message for their robot.... >:(

On Mon, Feb 4, 2013 at 5:46 PM, Dirk Thomas [email protected]:

The patch has been merged. The Wiki page must be updated but only after a
new release is in the public repo.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-13110680.

@dirk-thomas
Copy link
Member

Merged #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants