Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid name collision with windows.h #365

Closed
wants to merge 2 commits into from
Closed

avoid name collision with windows.h #365

wants to merge 2 commits into from

Conversation

kejxu
Copy link
Contributor

@kejxu kejxu commented Feb 19, 2019

winerror.h is implicitly included in source code and NO_ERROR is defined as a macro inside it. In order to use tf2_msgs::TF2Error::NO_ERROR correctly, NO_ERROR from winerror.h needs to be un-defined to avoid name collision

@seanyen seanyen mentioned this pull request Mar 18, 2019
Closed
@seanyen
Copy link
Contributor

seanyen commented Oct 2, 2019

cc @tfoote just a friendly ping, in case this and #361 is out of your radar. Let me and @kejxu know if any feedback.

@seanyen
Copy link
Contributor

seanyen commented Jan 14, 2020

@tfoote Happy new year. This and #361 is ready for review and merge. Hope we can move this forward for noetic and melodic.

@seanyen seanyen mentioned this pull request Jan 30, 2020
Merged
@kejxu kejxu closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kejxu @seanyen