[windows] reducing the odds to have name collisions #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirk-thomas @tfoote This is ready for review and merge. And let me know what do you think about this change. |
dirk-thomas
reviewed
Feb 7, 2020
|
@dirk-thomas I did some edits to address the feedback. This is ready for review again. Thanks! |
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with some effort to reduce the expose of
Windows.hfrom several ROS repositories. There are still changes that some external dependencies includingWindows.h.This pull request is to propose a mitigation to conditionally
#undefthe type of names with higher odds to have name collision on Windows side. And the goal is to reduce the odds from name collisions without extensive touch-ups on downstream projects.Here are some examples where the name collisions happen:
(it is not a full list. I will be collecting as I find it..)