[noetic port] Use setuptools instead of distutils #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sloretz @mjcarroll This is ready for review and merge. Thanks. |
sloretz
reviewed
Mar 12, 2020
actionlib/package.xml
Outdated
| @@ -20,6 +22,8 @@ | |||
| <author>Mikael Arguedas</author> | |||
|
|
|||
| <buildtool_depend version_gte="0.5.78">catkin</buildtool_depend> | |||
| <buildtool_depend condition="$ROS_PYTHON_VERSION == 2">python-setuptools</buildtool_depend> | |||
There was a problem hiding this comment.
Since this is targeting a noetic-devel branch, there's no need to include a <buildtool_depend> for either ROS_PYTHON_VERSION 2 or 3. As of ros/catkin#1048 catkin exports the dependency on python3-setuptools for the convenience of all downstream python packages.
There was a problem hiding this comment.
Good to know that. I reverted the package.xml changes.
sloretz
approved these changes
Mar 12, 2020
mjcarroll
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to apply the
noeticmigration by this ROS Wiki: http://wiki.ros.org/noetic/MigrationP.S. Updating it to
setuptoolshelps packaging system such likecondapackages passing--single-version-externally-managedto avoid Pythonegggeneration.