Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color tinting for mesh markers #752

Merged
merged 1 commit into from
Apr 30, 2014
Merged

Color tinting for mesh markers #752

merged 1 commit into from
Apr 30, 2014

Conversation

jbrindza
Copy link
Contributor

Fix bug where marker message color was overriding material color.
Allow color tinting for texture mapped material and non-texture mapped.

Shows color tinting for textured mesh and untextured for (0,0,0,0), (1,0,0,0.5) and (0,0,1,0.5) marker colors:
screenshot from 2014-04-28 19 30 26

to allow applying a color tint to the mesh
@wjwwood
Copy link
Member

wjwwood commented Apr 29, 2014

Thanks for this, I'm assuming this is supposed to be a fix for #751?

@jbrindza
Copy link
Contributor Author

Yes

@wjwwood
Copy link
Member

wjwwood commented Apr 29, 2014

Can you provide the script which you used to produce the image above?

@jbrindza
Copy link
Contributor Author

You can check out the example package here: https://github.com/brindza/rviz_collada_marker

roslaunch rviz_collada_marker test.launch

@wjwwood
Copy link
Member

wjwwood commented Apr 29, 2014

Thanks, I'll give it a whirl.

@wjwwood
Copy link
Member

wjwwood commented Apr 30, 2014

This seems to work fine for me.

@garaemon @hersh if you guys don't see anything wrong with this pull request I would propose merging it.

@garaemon
Copy link
Contributor

It works fine for me too!

@wjwwood
Copy link
Member

wjwwood commented Apr 30, 2014

@hersh, It looks like this pull request addresses @garaemon's original problem as well as allows for tinted meshes, so I'm going to go ahead and merge this. If you find something wrong with it later, please comment here.

wjwwood added a commit that referenced this pull request Apr 30, 2014
Color tinting for mesh markers
@wjwwood wjwwood merged commit 254c1f5 into ros-visualization:hydro-devel Apr 30, 2014
@hersh
Copy link
Contributor

hersh commented Apr 30, 2014

+1. :)

@ellislm ellislm mentioned this pull request Jun 4, 2015
xbroquer added a commit to xbroquer/rviz that referenced this pull request Jul 18, 2019
…w everything as white

Re-integrate patch from ros-visualization#752 Color tinting for mesh markers

Signed-off-by: Xavier BROQUERE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants