skip EOL distros by default, add option to include them #647
Conversation
|
Two of the Travis builds fail for unrelated reasons and are already present on the master branch. |
src/rosdep2/sources_list.py
Outdated
| @@ -439,7 +439,8 @@ def _generate_key_from_urls(urls): | |||
|
|
|||
|
|
|||
| def update_sources_list(sources_list_dir=None, sources_cache_dir=None, | |||
| success_handler=None, error_handler=None): | |||
| success_handler=None, error_handler=None, | |||
| include_eol_distros=False): | |||
There was a problem hiding this comment.
The new parameter can be added to the docstring.
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
- Coverage 75.29% 75.17% -0.13%
==========================================
Files 30 30
Lines 2882 2888 +6
==========================================
+ Hits 2170 2171 +1
- Misses 712 717 +5
Continue to review full report at Codecov.
|
|
@wjwwood FYI. I will go ahead and merge and release this change (even though CI fails). |
With ros-infrastructure/rosdep#647 rosdistros that are no longer supported don't have rosdep updates fetched. The system tests relied on groovy updates from rosdep. I've moved the system test to melodic. I chose melodic rather than indigo or kinetic because indigo will enter end-of-support later this year and Kinetic is currently supported on only one Debian/Ubuntu distro. Melodic is still supported on Bionic and Stretch.
With ros-infrastructure/rosdep#647 rosdistros that are no longer supported don't have rosdep updates fetched. The system tests relied on groovy updates from rosdep. I've moved the system test to melodic. I chose melodic rather than indigo or kinetic because indigo will enter end-of-support later this year and Kinetic is currently supported on only one Debian/Ubuntu distro. Melodic is still supported on Bionic and Stretch.
@dirk-thomas: This change only affects EOL systems (incl. CI ;)), so a post on ROS discourse might be more suitable to reach these legacy users. |
|
With the increasing number of already EOLed ROS distros the time for
rosdep updateincreases with it.Currently
groovy,hydroandjadeare EOLed ROS 1 distros. With the merge of the ROS 2 distro into the same repoardentwill be another EOLed one.This patch changes the default behavior of
rosdep updateto not fetch / consider EOLed distros which will improve its performance. The new option--include-eol-distroscan be used to continue including EOLed distros.