Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include EOL distros in rosdep update #352

Merged
merged 3 commits into from
Feb 2, 2019

Conversation

mathias-luedtke
Copy link
Member

@mathias-luedtke mathias-luedtke commented Jan 27, 2019

Addresses ros-infrastructure/rosdep#647
The flag will only be set for EOL distros on systems which support this flag.

@mathias-luedtke mathias-luedtke requested a review from 130s January 27, 2019 11:51
@mathias-luedtke
Copy link
Member Author

mathias-luedtke commented Jan 27, 2019

Perhaps we want to inlcude an opt-out for users of EOL Docker images, which might not ship the new flag.

Copy link
Member

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clarification comments added.

Same as #351 (review) I leave the merge up to you.

industrial_ci/src/tests/source_tests.sh Show resolved Hide resolved
industrial_ci/src/tests/source_tests.sh Show resolved Hide resolved
@130s 130s merged commit 8e81016 into ros-industrial:master Feb 2, 2019
@mathias-luedtke mathias-luedtke deleted the fix-eol-update branch February 3, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants