Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools instead of distutils #429

Merged

Conversation

matthew-reynolds
Copy link
Member

Use setuptools rather than distutils. See http://wiki.ros.org/noetic/Migration and ros/catkin#1048.

This PR also removes shebangs from setup.py files, since they should not be executed directly.

Note that it is not necessary to update all package.xml versions to 3, it is only required for packages containing setup.py files. But I updated them all for consistency.

@matthew-reynolds
Copy link
Member Author

hmm... Not sure why these egg-infos are being generated. Looking into it.

@bmagyar
Copy link
Member

bmagyar commented Mar 13, 2020

Is this something that we could also leverage in melodic?

@matthew-reynolds
Copy link
Member Author

Yeah, in fact it should be cherry picked back to Kinetic as well, once the issues are resolved. ros/catkin#1048 updated the recommended tool from Kinetic onwards.

Regarding the egg-info issue, this is being tracked upstream at ros/catkin#1069.

@ahcorde
Copy link
Contributor

ahcorde commented Apr 2, 2020

Hi @matthew-reynolds and @bmagyar any updates here? These changes are need it for release the package in Noetic

@matthew-reynolds
Copy link
Member Author

any updates here?

Waiting on the upstream issue ros/catkin#1069. I just submitted a PR to address this (ros/catkin#1073), but I am not very well versed in the catkin codebase so I expect some discussion and iteration before that's resolved.

@matthew-reynolds
Copy link
Member Author

Upstream PR merged into noetic-devel (ros/catkin#1073), just waiting on a backport to kinetic-devel now.

@matthew-reynolds
Copy link
Member Author

Upstream backport is done. Waiting on next catkin release (ros/rosdistro#24386). Once that is done, we can re-run this PR's tests, but only half of our tests will pass (the ros-testing ones) until the next Melodic sync.

@bmagyar bmagyar mentioned this pull request Apr 23, 2020
5 tasks
@bmagyar bmagyar changed the base branch from melodic-devel to noetic-devel May 9, 2020 12:39
@bmagyar bmagyar force-pushed the noetic-migration branch from c15eaa9 to c95b43a Compare May 9, 2020 16:06
@bmagyar
Copy link
Member

bmagyar commented May 9, 2020

Rebased to noetic and ready to merge when CI is happy

@bmagyar bmagyar merged commit 82c926c into ros-controls:noetic-devel May 9, 2020
@matthew-reynolds matthew-reynolds deleted the noetic-migration branch June 8, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants