-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setuptools instead of distutils #429
Use setuptools instead of distutils #429
Conversation
hmm... Not sure why these |
Is this something that we could also leverage in melodic? |
Yeah, in fact it should be cherry picked back to Kinetic as well, once the issues are resolved. ros/catkin#1048 updated the recommended tool from Kinetic onwards. Regarding the |
Hi @matthew-reynolds and @bmagyar any updates here? These changes are need it for release the package in Noetic |
Waiting on the upstream issue ros/catkin#1069. I just submitted a PR to address this (ros/catkin#1073), but I am not very well versed in the |
Upstream PR merged into |
Upstream backport is done. Waiting on next catkin release (ros/rosdistro#24386). Once that is done, we can re-run this PR's tests, but only half of our tests will pass (the |
Rebased to noetic and ready to merge when CI is happy |
Use
setuptools
rather thandistutils
. See http://wiki.ros.org/noetic/Migration and ros/catkin#1048.This PR also removes shebangs from
setup.py
files, since they should not be executed directly.Note that it is not necessary to update all
package.xml
versions to 3, it is only required for packages containingsetup.py
files. But I updated them all for consistency.