Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using setuptools generates egg-info folders in source space when installing #1069

Closed
matthew-reynolds opened this issue Mar 13, 2020 · 6 comments

Comments

@matthew-reynolds
Copy link
Contributor

matthew-reynolds commented Mar 13, 2020

Continuing the conversation from #1048 (comment). Using setuptools, as is now recommended:

egg-info folders are created in the source space when building Melodic packages w/ python 2 on Bionic. This seems to only happen when installing (ie. catkin_make install). (See https://travis-ci.org/github/ros-controls/ros_control/jobs/661982516?utm_medium=notification&utm_source=github_status)

Steps to reproduce:

cd /tmp
mkdir -p mel_ws/src
cd mel_ws/src
git clone [email protected]:ros/angles.git
chmod a-w -R angles
cd /tmp/mel_ws
catkin config --install; catkin build         # Fails
catkin clean
catkin_make install                           # Fails
catkin_make_isolated --install                # Fails
@matthew-reynolds
Copy link
Contributor Author

FYI @sloretz @mikepurvis

@mikepurvis
Copy link
Member

mikepurvis commented Mar 13, 2020

Oh, it's a Py2 issue—that might explain why I'm not hitting it as we're now migrated.

@dirk-thomas
Copy link
Member

What setuptools version are you using (pip freeze --all | grep setuptools)?

@sloretz
Copy link
Contributor

sloretz commented Mar 13, 2020

What setuptools version are you using (pip freeze --all | grep setuptools)?

I'm able to reproduce with setuptools==39.0.1

@matthew-reynolds
Copy link
Contributor Author

matthew-reynolds commented Mar 13, 2020

What setuptools version are you using (pip freeze --all | grep setuptools)?

I'm using setuptools==41.0.1. Not sure what version the Travis build I linked used though.

Edit: I can still reproduce the issue with setuptools=44.0.0, which AFAIK is the latest version that is Py2.7 compatible.

@dirk-thomas
Copy link
Member

Addressed in #1073.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants