Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygraphviz functions updated #812

Merged

Conversation

sachinkum0009
Copy link
Contributor

the functions of graphviz are changed to the functions of pygraphviz

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments

Also please for future PRs and for git in general try to avoid commit messages such as "minor changes", "fix review comments"

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@bmagyar
Copy link
Member

bmagyar commented Sep 19, 2022

for completeness I've uploaded a sample here:

g.pdf

yes there are some issues to work out but this PR should get us past the release block

@bmagyar bmagyar merged commit fe1d47c into ros-controls:master Sep 19, 2022
@bmagyar
Copy link
Member

bmagyar commented Sep 19, 2022

@Mergifyio backport to humble

mergify bot pushed a commit that referenced this pull request Sep 19, 2022
(cherry picked from commit fe1d47c)
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2022

backport to humble

✅ Backports have been created

bmagyar pushed a commit that referenced this pull request Sep 19, 2022
(cherry picked from commit fe1d47c)

Co-authored-by: Sachin Kumar <[email protected]>
christophfroehlich added a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants