Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Forward OPENSSL_ROOT_DIR to builtin xrootd #15697

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

guitargeek
Copy link
Contributor

It was tested that this works by building openssl on Arch Linux in a random directory and setting this as the OPENSSL_ROOT_DIR.

Then, I checked in the cache for the xrootd builtin external project if openssl was found in the desired location:

builtins/xrootd/BUILTIN_XROOTD-prefix/src/BUILTIN_XROOTD-build/CMakeCache.txt

This was the case indeed.

Closes #10075.

It was tested that this works by building openssl on Arch Linux in a
random directory and setting this as the `OPENSSL_ROOT_DIR`.

Then, I checked in the cache for the xrootd builtin external project if
openssl was found in the desired location:
```
builtins/xrootd/BUILTIN_XROOTD-prefix/src/BUILTIN_XROOTD-build/CMakeCache.txt
```

This was the case indeed.
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonas!

Copy link

github-actions bot commented May 31, 2024

Test Results

    12 files      12 suites   2d 22h 47m 34s ⏱️
 2 643 tests  2 643 ✅ 0 💤 0 ❌
29 989 runs  29 989 ✅ 0 💤 0 ❌

Results for commit 7fc3711.

♻️ This comment has been updated with latest results.

@dpiparo
Copy link
Member

dpiparo commented Jun 1, 2024

I restarted the builds @guitargeek . Also for me the PR can be merged once those are successful.

@guitargeek guitargeek merged commit e700aba into root-project:master Jun 1, 2024
15 checks passed
@guitargeek guitargeek deleted the issue-10075 branch June 1, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficult to configure Xrootd to use non-builtin openssl
3 participants