Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to configure Xrootd to use non-builtin openssl #10075

Closed
Axel-Naumann opened this issue Mar 8, 2022 · 4 comments · Fixed by #15697
Closed

Difficult to configure Xrootd to use non-builtin openssl #10075

Axel-Naumann opened this issue Mar 8, 2022 · 4 comments · Fixed by #15697

Comments

@Axel-Naumann
Copy link
Member

Explain what you would like to see improved

In builtins/xrootd/CMakeLists.txt we don't pass any openssl configuration over to Xrootd. This causes inconsistent builds for ROOT and xrootd.

Optional: share how it could be improved

Maybe use

OPENSSL_CRYPTO_LIBRARY
OPENSSL_SSL_LIBRARY
OPENSSL_INCLUDE_DIR

as made available with Xrootd's CMakeLists.txt.

To Reproduce

See https://root-forum.cern.ch/t/building-from-source-root-v6-26-00-failing-with-openssl-on-macos-monterey/49078

@bellenot
Copy link
Member

@Axel-Naumann According to the Xrootd README, the only OpenSSL related variable we can pass is OPENSSL_ROOT_DIR. Not sure it would solve this issue...

@dpiparo
Copy link
Member

dpiparo commented May 17, 2024

@amadio what's your take on this?

@amadio
Copy link
Member

amadio commented May 17, 2024

XRootD now uses the standard CMake module to link against OpenSSL. If you configure ROOT correctly, you should be able to just forward the OpenSSL variables to XRootD and it should work. If not, please let me know.

@guitargeek
Copy link
Contributor

Only one line of change needed to close an issue? Let's go:

@guitargeek guitargeek modified the milestone: 6.32/02 Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants