Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add collection info drawer #1341

Merged
merged 11 commits into from
Dec 4, 2024
Merged

feat: Add collection info drawer #1341

merged 11 commits into from
Dec 4, 2024

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Dec 3, 2024

  • New drawer with platform info added
  • Extra: added contextual menu to game cards. Now it's possible to open in a new tab with right-click
  • Extra: aligned to bottom when showing covers with different aspect ratio at the same time

TODO:

  • Store the last visited collection in memory for faster load on return

Depends on:

@zurdi15 zurdi15 self-assigned this Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Test Results

88 tests  ±0   88 ✅ ±0   25s ⏱️ -4s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f3522b9. ± Comparison against base commit 5b39127.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 marked this pull request as ready for review December 3, 2024 15:51
@zurdi15 zurdi15 requested review from adamantike and gantoine and removed request for adamantike December 3, 2024 15:51
@zurdi15 zurdi15 marked this pull request as draft December 3, 2024 16:07
@zurdi15 zurdi15 marked this pull request as ready for review December 3, 2024 18:01
@zurdi15 zurdi15 merged commit db55006 into master Dec 4, 2024
7 checks passed
@zurdi15 zurdi15 deleted the feature/collection-drawer branch December 4, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants