Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add platform info drawer + per platform settings #1324

Merged
merged 46 commits into from
Dec 3, 2024
Merged

feat: Add platform info drawer + per platform settings #1324

merged 46 commits into from
Dec 3, 2024

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Nov 28, 2024 •
edited
Loading

  • New drawer with platform info added
  • Removed some unnecessary API calls
  • Adapted covers to platform selected aspect ratio
  • Added platform icon in the recently added section
  • Added action bar to the search dialog
  • Now the last visited platform is stored in memory, loading it faster when going back to it from another view

TODO:

  • Cover aspect-ratio per platform

@zurdi15 zurdi15 self-assigned this Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Test Results

88 tests  ±0   88 ✅ ±0   26s ⏱️ -3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5eefdda. ± Comparison against base commit 96e5e30.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 mentioned this pull request Nov 29, 2024
Closed
@zurdi15 zurdi15 marked this pull request as ready for review December 2, 2024 11:26
@zurdi15 zurdi15 added feature New feature or request ui/ux UI/UX improvements or suggestions labels Dec 2, 2024
@zurdi15 zurdi15 changed the title Add platform info drawer + per platform settings feat: Add platform info drawer + per platform settings Dec 2, 2024
@zurdi15 zurdi15 requested a review from adamantike December 3, 2024 10:52
@zurdi15 zurdi15 mentioned this pull request Dec 3, 2024
Merged
1 task
adamantike
adamantike approved these changes Dec 3, 2024
View reviewed changes
backend/handler/metadata/igdb_handler.py
@@ -745,6 +785,7 @@ async def get_oauth_token(self) -> str:
"similar_games.name",
"similar_games.cover.url",
"age_ratings.rating",
"videos.video_id",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@zurdi15 zurdi15 merged commit a6ff9ba into master Dec 3, 2024
9 checks passed
@zurdi15 zurdi15 deleted the feature/add-platform-info branch December 3, 2024 18:01
@zurdi15 zurdi15 mentioned this pull request Dec 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamantike adamantike adamantike approved these changes

@gantoine gantoine Awaiting requested review from gantoine

Assignees

@zurdi15 zurdi15

Labels
feature New feature or request ui/ux UI/UX improvements or suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zurdi15 @adamantike