Fix fabric8io#1578: Fmp is generating ImageChange triggers in the Dep…

…loymentConfig Fixed my mistake while refactoring Converters into Enrichers
rohanKanojia · Mar 19, 2019 · fce7c91 · fce7c91
1 parent 3a17aa4
commit fce7c91
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,7 +10,11 @@ We use semantic versioning in some slight variation until our feature set has st
 
 After this we will switch probably to real [Semantic Versioning 2.0.0](http://semver.org/)
 
-### 4.0.0-M3
+### 4.0-SNAPSHOT
+* Fix 1578: Fmp is generating ImageChange triggers in the DeploymentConfig
+
+
+### 4.0.0 (14-03-2019)
 * Refactor 678: Enricher Workflow to allow direct generation of OpenShift objects.
 * Refactor 802: Remove resource object post processing.
 * Feature 729: Select custom resources depending on environment.

diff --git a/.../src/main/java/io/fabric8/maven/enricher/standard/openshift/DeploymentConfigEnricher.java b/.../src/main/java/io/fabric8/maven/enricher/standard/openshift/DeploymentConfigEnricher.java
@@ -146,7 +146,7 @@ private DeploymentConfig convert(HasMetadata item, Boolean isOpenshiftBuildStrat
                         specBuilder.addNewTrigger()
                                 .withType("ImageChange")
                                 .withNewImageChangeParams()
-                                .withAutomatic(true)
+                                .withAutomatic(enableAutomaticTrigger)
                                 .withNewFrom()
                                 .withKind("ImageStreamTag")
                                 .withName(image.getSimpleName() + ":" + tag)