4.0.0 is generating ImageChange triggers in the DeploymentConfig

[mojsha]

Description

It seems like 4.0.0 has reverted to generating ImageChange triggers for OpenShift DeploymentConfig objects with the automatic field set to true, e.g.

    - imageChangeParams:
        automatic: true
        containerNames:
          - sample-t-demo
        from:
          kind: ImageStreamTag
          name: 'demo:1.0.40-Stable-Release'
          namespace: sample-t
        lastTriggeredImage: >-
          docker-registry.default.svc:5000/sample-t/demo@sha256:5a41e6403eafb57c8ffb9e6f46470d3d697171f400a44b1f2d323a14144e26bf

This needs to be fixed, and the flag to disable this re-introduced.

• f-m-p version :
  4.0.0

• Kubernetes / OpenShift setup and version :
  3.10

• If it's a bug, how to reproduce :
  mvn fabric8:resource fabric8:build fabric8:apply on a project with a DeploymentConfig

@rohanKanojia

[rohanKanojia]

@mojsha : just looked , I think flag is still there :

fabric8-maven-plugin/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java

Lines 264 to 265 in 3a17aa4

	@Parameter(property = "fabric8.openshift.enableAutomaticTrigger", defaultValue = "true")
	private Boolean enableAutomaticTrigger;

Are you facing this issue when using resource fragments? I think we missed flag here while refactoring:

fabric8-maven-plugin/enricher/standard/src/main/java/io/fabric8/maven/enricher/standard/openshift/DeploymentConfigEnricher.java

Lines 146 to 156 in 3a17aa4

	specBuilder.addNewTrigger()
	.withType("ImageChange")
	.withNewImageChangeParams()
	.withAutomatic(true)
	.withNewFrom()
	.withKind("ImageStreamTag")
	.withName(image.getSimpleName() + ":" + tag)
	.withNamespace(image.getUser())
	.endFrom()
	.withContainerNames(containerName)
	.endImageChangeParams()

[mojsha]

@rohanKanojia I am not sure since I haven't followed the code changes, but yes I am using a DC resource fragments and in the existing version (3.5.42) I don't get this ImageChangeTrigger added.

[rohanKanojia]

Are you talking about withAutomatic(true) thing or the image trigger getting added?

[mojsha]

@rohanKanojia Yes precisely.The consequence is the extract I added in the first post, i.e. "automatic: true".