feature/mx-1502 wikidata results refactor #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tractors into feature/mx-1502-wikidata-results-refactor
mr-kamran-ali
changed the title
cutoffthetop
requested changes
Apr 3, 2024
erichesse
reviewed
Apr 9, 2024
If I have your ok, I can take care of this as well by making the process very similar to other extractors wikidata implementation. that is to separate extraction, transformation and load in main file. |
cutoffthetop
requested changes
Apr 10, 2024
…tractors into feature/mx-1502-wikidata-results-refactor
mr-kamran-ali
commented
Apr 16, 2024
There was a problem hiding this comment.
@cutoffthetop Temporal entity stuff in international projects extract and its testing, is still not perfect yet, have a look at changes in mex-common(robert-koch-institut/mex-common#157), they need to be merged as well, its a breaking change if this PR is merged into mex-extractors main.
…tractors into feature/mx-1502-wikidata-results-refactor
Signed-off-by: Nicolas Drebenstedt <[email protected]>
…tractors into feature/mx-1502-wikidata-results-refactor
…tractors into feature/mx-1502-wikidata-results-refactor
…ithub.com/robert-koch-institut/mex-extractors into feature/mx-1502-wikidata-results-refactor
cutoffthetop
changed the title
…tractors into feature/mx-1502-wikidata-results-refactor
cutoffthetop
approved these changes
May 16, 2024
rababerladuseladim
added a commit
to robert-koch-institut/mex-common
that referenced
this pull request
May 21, 2024
# PR Context - blocked by: robert-koch-institut/mex-extractors#39 as testing is only possible after the mex-common dependency in mex-extractors is updated to v0.24.0 - Bug: the first test that is executed does not receive isolated settings. It therefore receives the production data as they are in mex-assets. If the test uses data from mex-assets, it will get a different result than if it is not executed first. - Reproduce: in mex-extractors, execute `pdm run pytest .\tests\sumo\test_extract.py::test_extract_cc1_data_model_nokeda` - passes if not executed as first test - fails if executed in isolation / as first test # Fixed - isolate settings context before first test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes