-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isolate settings context before first test #158
isolate settings context before first test #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm the bug, I couldn't confirm the fix. when I install mex-extractors
witht "mex-common@git+https://github.com/robert-koch-institut/[email protected]@hotfix/isolate-settings-context-before-first-test"
in pyproject.toml
, the error seems to persist. How did you test the fix?
Also, should there also be a hotfix version be bumped for mex-common?
I bumped the version and will create a new release once this is merged into main. Regarding testing, I do not really know how to address this. Running the reproduction step on main of mex-extractors will results in this bug. Updating mex-common to 0.24.0 introduces a whole lot of breaking changes, which Kamran is currently addressing in his PR. Hence, testing this is only possible after Kamran finishes his PR. I tested this manually by applying the changed to the installed version of mex-common in the mex-extractors venv. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test these changes, after tests are fixed in /pull/157 and PR is merged
…efore-first-test # Conflicts: # CHANGELOG.md # pyproject.toml
@erichesse Could you review again? I created a branch using this version of mex-common in mex-extractors for testing: robert-koch-institut/mex-extractors#68 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Looks good now
PR Context
pdm run pytest .\tests\sumo\test_extract.py::test_extract_cc1_data_model_nokeda
Fixed