feature/mx-1702 resolve types in edit view #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor into feature/mx-1702-resolve-types
…itor into feature/mx-1702-resolve-types
cutoffthetop
added a commit
to robert-koch-institut/mex-common
that referenced
this pull request
Oct 11, 2024
# PR Context - prep for robert-koch-institut/mex-editor#158 # Added - add pattern constants for vocabs, emails, urls and ids to types module - add regex pattern to json schema of identifier fields - automatically add examples and useScheme to json schema of enum fields # Changes - BREAKING: use `identifier` instead of `stableTargetId` to get merged item from backend - ensure identifier unions are typed to generic `Identifier` instead of the first match - to signal that we don't actually know which of the union types is correct - unify pydantic schema configuration for all types - consistently parse emails, identifiers and temporals in models to their type, not str - consistently serialize emails, ids and temporals in models to str, not their type - make instances of Link type hashable, to harmonize them with Text models # Removed - drop manual examples from enum fields, because they are autogenerated now - BREAKING: remove `MEX_ID_PATTERN` from types, in favor of `IDENTIFIER_PATTERN` - BREAKING: make public `MEX_ID_ALPHABET` constant from identifier module private - BREAKING: remove `__str__` methods from Text and Link classes - BREAKING: drop support for parsing UUIDs as Identifiers, this was unused - BREAKING: drop support for parsing Links from markdown syntax, this was unused - BREAKING: remove pydantic1-style `validate` methods from all type models - BREAKING: `BackendApiConnector.post_models` in favor of `post_extracted_items` --------- Signed-off-by: Nicolas Drebenstedt <[email protected]> Co-authored-by: rababerladuseladim <[email protected]>
cutoffthetop
added a commit
to robert-koch-institut/mex-backend
that referenced
this pull request
Oct 17, 2024
# PR Context - prep for robert-koch-institut/mex-editor#158 # Changed - silence neo4j missing label warnings, because we will likely never need all labels - sort search results by `identifier` and `entityType` to ensure a more stable order - improve handling of pydantic validation errors and uncaught errors # Removed - remove already obsolete module `mex.backend.serialization` this is not needed any more with the new mex-common version # Fixed - fix how merged edges are counted (currently only used for debugging)
…itor into feature/mx-1702-resolve-types
…itor into feature/mx-1702-resolve-types
…itor into feature/mx-1702-resolve-types
# PR Context - needs robert-koch-institut/mex-common#207 # Added <!-- New features and interfaces --> # Changes - updated the model config for preview of search results for model v3 # Deprecated <!-- Soon-to-be removed features --> # Removed <!-- Definitely removed features --> # Fixed <!-- Fixed bugs --> # Security <!-- Fixed vulnerabilities --> Co-authored-by: Franziska Diehr <[email protected]>
…bert-koch-institut/mex-editor into feature/mx-1702-resolve-types
…#181) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ghcr.io/robert-koch-institut/mex-backend](https://github.com/robert-koch-institut/mex-backend) | service | minor | `0.20.0` -> `0.21.0` | --- ### Release Notes <details> <summary>robert-koch-institut/mex-backend (ghcr.io/robert-koch-institut/mex-backend)</summary> ### [`v0.21.0`](https://github.com/robert-koch-institut/mex-backend/blob/HEAD/CHANGELOG.md#0210---2024-10-31) [Compare Source](https://github.com/robert-koch-institut/mex-backend/compare/0.20.0...0.21.0) ##### Changes - upgrade mex-common and mex-model dependencies to metadata model v3 - apply additional linters in prep for `all` ruff linters </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDAuMiIsInVwZGF0ZWRJblZlciI6IjM4LjE0MC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
…bert-koch-institut/mex-editor into feature/mx-1702-resolve-types
rababerladuseladim
requested changes
Nov 13, 2024
Co-authored-by: rababerladuseladim <[email protected]> Signed-off-by: Nicolas Drebenstedt <[email protected]>
Co-authored-by: rababerladuseladim <[email protected]> Signed-off-by: Nicolas Drebenstedt <[email protected]>
Co-authored-by: rababerladuseladim <[email protected]> Signed-off-by: Nicolas Drebenstedt <[email protected]>
…bert-koch-institut/mex-editor into feature/mx-1702-resolve-types
…itor into feature/mx-1702-resolve-types
rababerladuseladim
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Context
Changes
Fixed