Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1702 prep editor types #168

Merged
merged 17 commits into from
Oct 17, 2024
Merged

feature/mx-1702 prep editor types #168

merged 17 commits into from
Oct 17, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Sep 30, 2024 •
edited
Loading

PR Context

Changed

  • silence neo4j missing label warnings, because we will likely never need all labels
  • sort search results by identifier and entityType to ensure a more stable order
  • improve handling of pydantic validation errors and uncaught errors

Removed

  • remove already obsolete module mex.backend.serialization
    this is not needed any more with the new mex-common version

Fixed

  • fix how merged edges are counted (currently only used for debugging)

rababerladuseladim
rababerladuseladim reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to complain, only some questions.

mex/backend/exceptions.py Show resolved Hide resolved
mex/backend/graph/cypher/fetch_merged_items.cql Outdated Show resolved Hide resolved
@cutoffthetop cutoffthetop merged commit 4b27e6b into main Oct 17, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1702-prep-editor-types branch October 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @rababerladuseladim