Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): workaround #7367 #7433

Merged
merged 2 commits into from
Jan 17, 2023
Merged

fix(test): workaround #7367 #7433

merged 2 commits into from
Jan 17, 2023

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jan 17, 2023

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

The meta backup-recovery test got stuck because frontend cannot receive expected error raised by compute node after #7367 when QUERY_MODE=local.
This PR SET QUERY_MODE=distributed to work around the problem temporarily.

Checklist

- [ ] I have written necessary rustdoc comments
- [ ] I have added necessary unit tests and integration tests
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).

  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/fix Bug fix label Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #7433 (f2edb4b) into main (06f2cc3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7433   +/-   ##
=======================================
  Coverage   72.91%   72.92%           
=======================================
  Files        1071     1071           
  Lines      172477   172477           
=======================================
+ Hits       125755   125771   +16     
+ Misses      46722    46706   -16     
Flag Coverage Δ
rust 72.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object_store/src/object/mod.rs 51.08% <0.00%> (-0.22%) ⬇️
src/storage/src/hummock/compactor/mod.rs 83.48% <0.00%> (ø)
src/storage/src/hummock/sstable_store.rs 64.68% <0.00%> (ø)
src/meta/src/hummock/manager/mod.rs 79.98% <0.00%> (+0.06%) ⬆️
src/stream/src/executor/aggregation/minput.rs 96.49% <0.00%> (+0.10%) ⬆️
src/storage/src/hummock/compactor/iterator.rs 98.25% <0.00%> (+0.29%) ⬆️
src/object_store/src/object/mem.rs 87.12% <0.00%> (+0.37%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.78% <0.00%> (+1.05%) ⬆️
src/batch/src/executor/group_top_n.rs 74.85% <0.00%> (+6.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 4878d5d into main Jan 17, 2023
@mergify mergify bot deleted the wangzheng/fix_backup_test branch January 17, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants