-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken channel reciever #7367
Conversation
566e9b4
to
23f5d74
Compare
ca40470
to
b3464ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b3464ab
to
e4e235d
Compare
Codecov Report
@@ Coverage Diff @@
## main #7367 +/- ##
==========================================
- Coverage 73.08% 73.04% -0.04%
==========================================
Files 1068 1069 +1
Lines 171815 171900 +85
==========================================
- Hits 125575 125571 -4
- Misses 46240 46329 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @BowenXiao1999, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
9c80fd8
to
6d26dc8
Compare
This reverts commit 5da5ad6.
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it. Approved-By: liurenjie1024 (cherry picked from commit 5da5ad6)
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it. Approved-By: liurenjie1024 (cherry picked from commit 5da5ad6)
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it. Approved-By: liurenjie1024 (cherry picked from commit 5da5ad6)
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it. Approved-By: liurenjie1024 (cherry picked from commit 5da5ad6)
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it. Approved-By: liurenjie1024 (cherry picked from commit 5da5ad6)
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
#7219 #7324