Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken channel reciever #7367

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Jan 13, 2023

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

#7219 #7324

@github-actions github-actions bot added the type/fix Bug fix label Jan 13, 2023
@BowenXiao1999 BowenXiao1999 force-pushed the bw/fix-broken-hash-shuffle-channel branch from 566e9b4 to 23f5d74 Compare January 13, 2023 03:23
@BowenXiao1999 BowenXiao1999 force-pushed the bw/fix-broken-hash-shuffle-channel branch 2 times, most recently from ca40470 to b3464ab Compare January 16, 2023 06:01
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BowenXiao1999 BowenXiao1999 force-pushed the bw/fix-broken-hash-shuffle-channel branch from b3464ab to e4e235d Compare January 16, 2023 06:20
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #7367 (e4e235d) into main (ca339df) will decrease coverage by 0.03%.
The diff coverage is 73.33%.

❗ Current head e4e235d differs from pull request most recent head 9c80fd8. Consider uploading reports for the commit 9c80fd8 to get more accurate results

@@            Coverage Diff             @@
##             main    #7367      +/-   ##
==========================================
- Coverage   73.08%   73.04%   -0.04%     
==========================================
  Files        1068     1069       +1     
  Lines      171815   171900      +85     
==========================================
- Hits       125575   125571       -4     
- Misses      46240    46329      +89     
Flag Coverage Δ
rust 73.04% <73.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/task/broadcast_channel.rs 0.00% <0.00%> (ø)
.../batch/src/task/consistent_hash_shuffle_channel.rs 0.00% <0.00%> (ø)
src/batch/src/task/hash_shuffle_channel.rs 0.00% <0.00%> (ø)
src/batch/src/task/task_execution.rs 53.66% <90.00%> (-0.13%) ⬇️
src/batch/src/task/channel.rs 61.53% <100.00%> (+3.84%) ⬆️
src/batch/src/task/fifo_channel.rs 86.48% <100.00%> (+0.37%) ⬆️
src/common/src/types/chrono_wrapper.rs 56.58% <0.00%> (-8.14%) ⬇️
src/stream/src/executor/watermark/mod.rs 64.28% <0.00%> (-6.63%) ⬇️
src/common/src/util/value_encoding/mod.rs 85.36% <0.00%> (-2.44%) ⬇️
src/expr/src/vector_op/cast.rs 89.81% <0.00%> (-1.01%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2023

Hey @BowenXiao1999, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

@BowenXiao1999 BowenXiao1999 force-pushed the bw/fix-broken-hash-shuffle-channel branch from 9c80fd8 to 6d26dc8 Compare January 16, 2023 12:35
@mergify mergify bot merged commit 5da5ad6 into main Jan 16, 2023
@mergify mergify bot deleted the bw/fix-broken-hash-shuffle-channel branch January 16, 2023 13:00
zwang28 added a commit that referenced this pull request Jan 17, 2023
@zwang28 zwang28 mentioned this pull request Jan 17, 2023
1 task
mergify bot pushed a commit that referenced this pull request Jan 17, 2023
The meta backup-recovery test got stuck because frontend cannot receive expected error raised by compute node after #7367 when QUERY_MODE=local.
This PR `SET QUERY_MODE=distributed` to work around the problem temporarily.

Approved-By: hzxa21
BowenXiao1999 added a commit that referenced this pull request Jan 18, 2023
mergify bot pushed a commit that referenced this pull request Jan 18, 2023
Revert previous commit, as it may brought some new bugs

Approved-By: liurenjie1024
BowenXiao1999 added a commit that referenced this pull request Jan 28, 2023
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it.

Approved-By: liurenjie1024

(cherry picked from commit 5da5ad6)
BowenXiao1999 added a commit that referenced this pull request Jan 30, 2023
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it.

Approved-By: liurenjie1024

(cherry picked from commit 5da5ad6)
BowenXiao1999 added a commit that referenced this pull request Jan 31, 2023
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it.

Approved-By: liurenjie1024

(cherry picked from commit 5da5ad6)
BowenXiao1999 added a commit that referenced this pull request Feb 2, 2023
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it.

Approved-By: liurenjie1024

(cherry picked from commit 5da5ad6)
BowenXiao1999 added a commit that referenced this pull request Feb 3, 2023
Basically the idea is store sender inside TaskExecution. And clone it out when we need to mut it.

Approved-By: liurenjie1024

(cherry picked from commit 5da5ad6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants