Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): deprecate persisted fragment upstream ids #20548

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 20, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

With fragment_relation table introduced, the upstream_fragment_id in fragment table becomes redundant. In this PR, we will deprecate the usage on this column.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 changed the title refactor(meta): deprecate dispatcher table and compose dispatcher by fragment relation refactor(meta): deprecate persisted fragment upstream ids Feb 20, 2025
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-fragment-upstream-ids branch from 304b97d to dbdb94c Compare February 21, 2025 07:46
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-dispatcher branch from 48b2492 to 3184ea9 Compare February 24, 2025 03:30
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-fragment-upstream-ids branch from dbdb94c to d6e3542 Compare February 24, 2025 03:30
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-dispatcher branch from 3184ea9 to 58a91ac Compare February 25, 2025 09:29
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-fragment-upstream-ids branch from d6e3542 to 5e461f1 Compare February 25, 2025 09:29
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-dispatcher branch from 58a91ac to 6889cce Compare February 25, 2025 10:07
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-fragment-upstream-ids branch from 5e461f1 to a63e9db Compare February 25, 2025 10:07
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-dispatcher branch from 6889cce to 533e6fe Compare February 27, 2025 07:03
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-fragment-upstream-ids branch from a63e9db to 43ba119 Compare February 27, 2025 07:03
Base automatically changed from yiming/deprecate-persisted-actor-dispatcher to main February 27, 2025 09:04
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-fragment-upstream-ids branch from 43ba119 to 6f8341c Compare February 27, 2025 09:30
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM! The dashboard also needs to be updated accordingly.

Comment on lines +33 to 34
#[deprecated]
pub upstream_fragment_id: I32Array,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to remove this field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May keep it for a release and remove it in the next release.

@wenym1 wenym1 added this pull request to the merge queue Feb 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2025
@wenym1 wenym1 added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 543b94a Feb 28, 2025
31 of 32 checks passed
@wenym1 wenym1 deleted the yiming/deprecate-persisted-fragment-upstream-ids branch February 28, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants