-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(meta): deprecate persisted fragment upstream ids #20548
refactor(meta): deprecate persisted fragment upstream ids #20548
Conversation
304b97d
to
dbdb94c
Compare
48b2492
to
3184ea9
Compare
dbdb94c
to
d6e3542
Compare
3184ea9
to
58a91ac
Compare
d6e3542
to
5e461f1
Compare
58a91ac
to
6889cce
Compare
5e461f1
to
a63e9db
Compare
6889cce
to
533e6fe
Compare
a63e9db
to
43ba119
Compare
43ba119
to
6f8341c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LSTM! The dashboard also needs to be updated accordingly.
#[deprecated] | ||
pub upstream_fragment_id: I32Array, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to remove this field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May keep it for a release and remove it in the next release.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
With
fragment_relation
table introduced, theupstream_fragment_id
infragment
table becomes redundant. In this PR, we will deprecate the usage on this column.Checklist
Documentation
Release note