Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): deprecate persisted actor upstreams and get upstreams from dispatcher info #20387

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 5, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously we persist both the dispatchers of upstream actors, and the actor upstream info of downstream actors in meta store. However, these two information should be semantically identical and duplicated, and we have to carefully maintain their consistency in our code.

In this PR, we will deprecate persisting the actor upstreams in the Actor table. In the original place to use it, we will always extract the actor upstreams information by the dispatcher info along with it. More specifically, we implement a method collect_actor_upstreams, which will generate the actor upstream information when we provide sufficient dispatcher information.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 force-pushed the yiming/stream-actor-share-stream-node branch from 71ee2c7 to b4113a5 Compare February 5, 2025 08:56
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-upstreams branch from ab5566b to 3699e89 Compare February 5, 2025 08:56
@wenym1 wenym1 force-pushed the yiming/stream-actor-share-stream-node branch from b4113a5 to cb388c1 Compare February 6, 2025 04:55
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-upstreams branch from 3699e89 to 4b20ca1 Compare February 6, 2025 04:55
@wenym1 wenym1 force-pushed the yiming/stream-actor-share-stream-node branch from cb388c1 to b4745d4 Compare February 6, 2025 05:16
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-upstreams branch from 4b20ca1 to fc889f2 Compare February 6, 2025 05:17
@wenym1 wenym1 force-pushed the yiming/stream-actor-share-stream-node branch 2 times, most recently from 0215686 to 6ce3060 Compare February 12, 2025 07:08
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-upstreams branch from fc889f2 to 32d2115 Compare February 12, 2025 07:09
Base automatically changed from yiming/stream-actor-share-stream-node to main February 13, 2025 07:13
Copy link

gru-agent bot commented Feb 13, 2025

❌ Rebase test pr failed: Error: Pull request #20387 is not created by gru-agent[bot]

@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-upstreams branch from 32d2115 to 1e14782 Compare February 13, 2025 07:52
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cc @shanicky PTAL, it should be related to the refactoring that you're working.

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@shanicky shanicky added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 5d2265b Feb 20, 2025
31 of 32 checks passed
@shanicky shanicky deleted the yiming/deprecate-persisted-actor-upstreams branch February 20, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants