-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(meta): deprecate persisted actor upstreams and get upstreams from dispatcher info #20387
Conversation
71ee2c7
to
b4113a5
Compare
ab5566b
to
3699e89
Compare
b4113a5
to
cb388c1
Compare
3699e89
to
4b20ca1
Compare
cb388c1
to
b4745d4
Compare
4b20ca1
to
fc889f2
Compare
0215686
to
6ce3060
Compare
fc889f2
to
32d2115
Compare
❌ Rebase test pr failed: Error: Pull request #20387 is not created by gru-agent[bot] |
32d2115
to
1e14782
Compare
… from dispatcher info
1e14782
to
80b265d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cc @shanicky PTAL, it should be related to the refactoring that you're working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously we persist both the dispatchers of upstream actors, and the actor upstream info of downstream actors in meta store. However, these two information should be semantically identical and duplicated, and we have to carefully maintain their consistency in our code.
In this PR, we will deprecate persisting the actor upstreams in the
Actor
table. In the original place to use it, we will always extract the actor upstreams information by the dispatcher info along with it. More specifically, we implement a methodcollect_actor_upstreams
, which will generate the actor upstream information when we provide sufficient dispatcher information.Checklist
Documentation
Release note