Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Vault address to be specified in .Values.environmentVars #113

Merged
merged 2 commits into from
Jun 16, 2021
Merged

feat: allow Vault address to be specified in .Values.environmentVars #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c3701
feat: allow Vault address to be specified in .Values.environmentVars
jaredallard Jun 15, 2021
476405e
remove default vault address
jaredallard Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/vault-secrets-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,10 @@ spec:
{{- else }}
value: ""
{{- end }}
{{- if .Values.vault.address }}
- name: VAULT_ADDRESS
value: {{ .Values.vault.address | quote }}
{{- end }}
- name: VAULT_AUTH_METHOD
value: {{ .Values.vault.authMethod | quote }}
- name: VAULT_TOKEN_PATH
Expand Down
2 changes: 1 addition & 1 deletion charts/vault-secrets-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ environmentVars: []
# will watch all namespaces. If the value is empty and rbac.namespaced is set to
# true, then the namespace of the release will be used.
vault:
address: "http://vault:8200"
address: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be breaking, open to different ways of doing this

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ok, the next release also contains a breaking change for the CRD handling of the Helm chart.

authMethod: token
tokenPath: ""
kubernetesPath: auth/kubernetes
Expand Down