feat: allow Vault address to be specified in .Values.environmentVars #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredallard
commented
Jun 15, 2021
| @@ -78,7 +78,7 @@ environmentVars: [] | |||
| # will watch all namespaces. If the value is empty and rbac.namespaced is set to | |||
| # true, then the namespace of the release will be used. | |||
| vault: | |||
| address: "http://vault:8200" | |||
| address: "" | |||
There was a problem hiding this comment.
This might be breaking, open to different ways of doing this
There was a problem hiding this comment.
This should be ok, the next release also contains a breaking change for the CRD handling of the Helm chart.
|
Hi @jaredallard, thanks for your contribution 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't include
VAULT_ADDRESSif it's not set at.Values.vault.address. This allows alternative ways of supplying the vault address to be used via.Values.environmentVars.My use case is that
VAULT_ADDRESSgets supplied after the helm chart has been rendered for our developer environment (think snapshots).