Fix the initial I-D so it builds successfully. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richsalz
approved these changes
Apr 6, 2020
repo_utils.py
Outdated
| """ | ||
| return template.format(**vars()) | ||
| return template.format(workgroup="" if wg is None else "workgroup: {}\n".format(wg), **vars()) |
There was a problem hiding this comment.
Maybe split that workgroup assignment into its own statement.
And remove an unnecessary date: key that wasn't filled in.
jyasskin
force-pushed
the
fix-initial-i-d
branch
from
b0b5d3e to
ab76042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #14; only the last 2 commits are new.