Initialize the repository inside the script. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of printing shell commands for the user to run. This also avoids adding files to the initial working directory, which should make it easier to pip-ify these scripts.
jyasskin
force-pushed
the
init-internally
branch
from
1204237 to
86699be
Compare
|
A tour de force. |
|
I can live with splitting imports into one line :) |
richsalz
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing shell commands for the user to run.
This also avoids adding files to the initial working directory, which should make it easier to pip-ify these scripts.
It would be possible to use https://gitpython.readthedocs.io/ for a Python interface to Git, but since some of the initialization commands need to be subprocesses anyway, it seemed more straightforward to just call out to the Git utility.