Revert "fix: remove invalid owner ref on cluster role (#460)"

This reverts commit fc12c57.
rhobs · Apr 18, 2024 · 1851f9b · 1851f9b
1 parent adf7630
commit 1851f9b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/controllers/monitoring/monitoring-stack/alertmanager.go b/pkg/controllers/monitoring/monitoring-stack/alertmanager.go
@@ -139,7 +139,8 @@ func newAlertManagerClusterRole(ms *stack.MonitoringStack, rbacResourceName stri
 			Kind:       "ClusterRole",
 		},
 		ObjectMeta: metav1.ObjectMeta{
-			Name: rbacResourceName,
+			Name:      rbacResourceName,
+			Namespace: ms.Namespace,
 		},
 		Rules: []rbacv1.PolicyRule{{
 			APIGroups:     []string{"security.openshift.io"},

diff --git a/pkg/reconciler/reconciler.go b/pkg/reconciler/reconciler.go
@@ -25,6 +25,7 @@ type Updater struct {
 }
 
 func (r Updater) Reconcile(ctx context.Context, c client.Client, scheme *runtime.Scheme) error {
+
 	if r.resourceOwner.GetNamespace() == r.resource.GetNamespace() {
 		if err := controllerutil.SetControllerReference(r.resourceOwner, r.resource, scheme); err != nil {
 			return fmt.Errorf("%s/%s (%s): updater failed to set owner reference: %w",
@@ -38,7 +39,6 @@ func (r Updater) Reconcile(ctx context.Context, c client.Client, scheme *runtime
 			r.resource.GetNamespace(), r.resource.GetName(),
 			r.resource.GetObjectKind().GroupVersionKind().String(), err)
 	}
-
 	return nil
 }