COO-117: fix: remove invalid owner ref on cluster role #460
Conversation
Cluster roles aren't namespace-scoped and can't have namespace-scoped owner references. Closes COO-117 Signed-off-by: Simon Pasquier <[email protected]>
|
@simonpasquier: This pull request references COO-117 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
@simonpasquier: This pull request references COO-117 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
simonpasquier
requested review from
sthaha and
slashpai
and removed request for
a team
|
/lgtm |
| @@ -39,6 +38,7 @@ func (r Updater) Reconcile(ctx context.Context, c client.Client, scheme *runtime | |||
| r.resource.GetNamespace(), r.resource.GetName(), | |||
| r.resource.GetObjectKind().GroupVersionKind().String(), err) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Thanks also for this style clean up. I'll try to have that automatically applied for the whole project ;)
This reverts commit fc12c57.
This reverts commit fc12c57.
Cluster roles aren't namespace-scoped and can't have namespace-scoped owner references.
Closes COO-117